Ticket #17 (closed defect: fixed)

Opened 3 years ago

Last modified 6 months ago

prompt errors?

Reported by: perry Assigned to: sontag
Priority: normal Milestone: PyRAF 1.6
Component: none Version:
Severity: minor Keywords:
Cc:

Description

Here are a few questions or comments that have occurred to me while looking over the pyraf code.

in iraffunctions.py:

Shouldn't these prompt strings include a trailing blank?

line 2505:

prompt2 = '>>>'

lines 2511 - 2513:

prompt = loadedPath[-1].getName()[:2] + '>'

else:

prompt = 'cl>'

in irafpar.py:

Whether the getValue method of IrafParList? prompts for a new value seems to depend only on the mode of the parameter, not on the mode argument. It looks as if this is due to the use of _cmdlineFlag in the _optionalPrompt method of IrafPar?. This seems a little obscure.

in iraftask.py:

line 988 (_run method of IrafPset?): # should executing a pset run epar?

I would say yes, since this is what the iraf cl does.

Change History

02/21/08 13:16:37 changed by sontag

  • owner changed from somebody to sontag.

02/21/08 13:21:08 changed by sontag

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to PyRAF 1.6.

1) The prompt issue was fixed by rlw in r669.

2) The IrafParList?.getValue() logic has been using the mode argument since before r602.

3) The running of epar when executing a pset issue was fixed today by sontag in r824.

02/21/08 13:29:58 changed by sontag

Example of the third issue:

--> noao
--> digiphot
--> apphot
--> datapars

02/21/08 15:43:06 changed by sontag

  • version deleted.